-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support reading from websockets #476
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Baroshem can we introduce some dependencies for some of the tests? (like websockets) Or should the module stay dependency-free? |
Hey there! The best would be to remain deps free 🙂 |
How would we test websockets in such case? Through nitro's built in websocket system? |
This will be refactored, the issue has been identified and is unrelated to the module, I'll open a PR in the responsible repo |
Thanks for investigation @GalacticHypernova. Should we close this PR or remain as is? |
It depends. Would you like me to make a custom data reading method to not rely on h3's? |
I dont think so. We are relying in H3 so I wouldnt test any other setup |
In that case we can close this, I forwarded the issue to h3 =) |
Types of changes
Description
This is a WIP PR to add support for reading messages from websockets, fixing #472 . It relies on the underlying socket in the connection and is therefore experimental. Due to the inability to test the module locally as stackblitz always regenerated the necessary file, I am adding this here to experiment with.
Checklist:
Tests will arrive later